/prog/ - Programming

Me again, so, so far I have this

// string repetition

#include <iostream>

#include <vector>

#include <string>

using namespace std;

int main()

{

vector<string> words;

vector<int> counter(2, 0);

cout << counter[0] << " " << counter[1] << endl;

string word = " ";

int fuckyall = 0;

string quit = "quit";

while(cin >> word && word != quit)

{

words.push_back(word);

}

string otherWord;

int i = 0;

for(auto beg = words.begin(); beg < words.end(); beg++)

{

word = words[i];

i++;

if(word == words[i])

{

while(word == words[i])

{

counter[1] + 1;

i++;

}

}

else

{

if(counter[1] > counter[0])

{

counter[0] = counter[1];

fuckyall = i;

}

}

}

cout << "The word " << words[fuckyall] << " was repeated " << counter[0] << " times." << endl;

return 0;

}

but when I run it, I do the input, and then it crashes, and I'm not sure what exactly is causing it as someone fairly new to programming.

also after posting I recognized an error in not resetting counter[1] after putting its value into counter[0]

>>2720

Add debug lines… and consider using .at() insted of [] on vectors

I wrote a solution for you, OP. I didn't end up using a vector, since you really only need to know two things each time you read a word:

- the previous word

- the number of times it has repeated

Also, instead of waiting for a magical "quit" word, I just used the eof() method to check for when the standard input file ended. At a terminal, you can indicate EOF in standard input by pressing CTRL-D on a new line. If you pipe a file to the command, it will automatically get an EOF at the end of the file.

I tried to put useful comments in place. Here it is:

#include <iostream>
#include <string>

using namespace std;

int main()
{
    // The word which occurred most
    string mostWord;
    // The number of times it occurred (set to 1, since it's the minimum)
    int mostCount = 1;

    // The last word we read
    string lastWord;
    // The new word we'll be reading
    string currWord;
    // The count for the number of times that the current word has repeated
    int currCount = 1;

    cin >> lastWord;
    while (cin >> currWord) {
        bool eof = cin.eof();

        if (lastWord == currWord && !eof) {
            // If the new word is the same as the last one, increase the count
            ++currCount;
        } else {
            // Check if we set a new record for most consecutive occurrences. If
            // we did, then update mostCount and mostWord accordingly.
            if (currCount > mostCount) {
                mostCount = currCount;
                mostWord = lastWord;
            }
            // Reset lastWord and currCount
            lastWord = currWord;
            currCount = 1;
        }
        // If we've reached the end of the file (e.g. someone pressed CTRL-D at
        // the terminal) then exit.
        if (eof) break;
    }

    // Print output
    if (mostCount > 1) {
        cout << "The string " << mostWord << " occurred " << mostCount <<
            " consecutive times.\n";
    } else {
        cout << "No duplicated words.\n";
    }

    return 0;
}

>>2726

Shoot, there are some problems with that code.

Please forgive me; I don't know C++ (only C, I had to look up the libraries to write this). Don't worry, this code doesn't leak any memory, at least (I actually ran it through valgrind because I *really* don't know C++, but it turned out alright).

Here is the revised code. You'll notice that we don't need to check for EOF, because apparently the >> operator does that for us on its own. I also added another test after the while loop; the reason for this will be left as an exercise for the reader.

#include <iostream>
#include <string>

using namespace std;

int main()
{
    // The word which occurred most
    string mostWord;
    // The number of times it occurred (set to 1, since it's the minimum)
    int mostCount = 1;

    // The last word we read
    string lastWord;
    // The new word we'll be reading
    string currWord;
    // The count for the number of times that the current word has repeated
    int currCount = 1;

    cin >> lastWord;
    while (cin >> currWord) {
        if (lastWord == currWord) {
            // If the new word is the same as the last one, increase the count
            ++currCount;
        } else {
            // Check if we set a new record for most consecutive occurrences. If
            // we did, then update mostCount and mostWord accordingly.
            if (currCount > mostCount) {
                mostCount = currCount;
                mostWord = lastWord;
            }
            // Reset lastWord and currCount
            lastWord = currWord;
            currCount = 1;
        }
    }

    // We need to check once more whether the last word was the most repeated
    if (currCount > mostCount) {
        mostCount = currCount;
        mostWord = lastWord;
    }

    // Print output
    if (mostCount > 1) {
        cout << "The string " << mostWord << " occurred " << mostCount <<
            " consecutive times.\n";
    } else {
        cout << "No duplicated words.\n";
    }

    return 0;
}

>>2727

Thanks, since I just got off a 12 hour day I'll save it and read over it later, I was probably over thinking the problem when I wrote the code… it was 1am and I hadn't slept in a couple days… fucking 80 degree nights